Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable diag collection for the prometheus exporter #35

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore: enable diag collection for the prometheus exporter #35

merged 1 commit into from
Jul 4, 2024

Conversation

jedel1043
Copy link
Contributor

Otherwise, the exporter only collects stats akin to the sinfo command, which is a lot less useful for monitoring.

@jedel1043 jedel1043 force-pushed the enable-sdiag-metrics branch 3 times, most recently from e842e8b to a39a30c Compare July 3, 2024 20:23
@NucciTheBoss NucciTheBoss self-requested a review July 3, 2024 22:35
@NucciTheBoss NucciTheBoss added the enhancement New feature or request label Jul 3, 2024
NucciTheBoss
NucciTheBoss requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! More diagnostic information the better 🤩

Just a couple of minor nits. Once those are addressed, I'm good to ship 🚢

snap/snapcraft.yaml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@jedel1043 jedel1043 force-pushed the enable-sdiag-metrics branch from a39a30c to 9096f9e Compare July 3, 2024 23:00
@jedel1043 jedel1043 marked this pull request as draft July 3, 2024 23:01
@jedel1043 jedel1043 changed the base branch from main to nuccitheboss/enhance-munge-api July 3, 2024 23:01
@jedel1043 jedel1043 requested a review from NucciTheBoss July 3, 2024 23:02
@jedel1043 jedel1043 changed the base branch from nuccitheboss/enhance-munge-api to main July 3, 2024 23:10
@jedel1043 jedel1043 force-pushed the enable-sdiag-metrics branch from 9096f9e to 6d4532c Compare July 3, 2024 23:18
@jedel1043 jedel1043 force-pushed the enable-sdiag-metrics branch from 6d4532c to c71da07 Compare July 3, 2024 23:19
@jedel1043 jedel1043 marked this pull request as ready for review July 3, 2024 23:19
NucciTheBoss
NucciTheBoss approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Although you might want to rebase this commit on top of the recently merged pull to add mungectl.

Once it's cleaned up you can merge!

@jedel1043
Copy link
Contributor Author

@NucciTheBoss It's pretty much rebased. I don't have permissions to merge though 😅

@NucciTheBoss
Copy link
Member

@NucciTheBoss It's pretty much rebased. I don't have permissions to merge though 😅

🤡 - I will fix up the permissions when I get back from holidaying

Terraform supports configuring GitHub orgs with plans. Be nice to check it out if we have some extra pulse time

@NucciTheBoss NucciTheBoss merged commit 068897e into charmed-hpc:main Jul 4, 2024
4 checks passed
@jedel1043 jedel1043 deleted the enable-sdiag-metrics branch July 4, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NucciTheBoss NucciTheBoss NucciTheBoss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @NucciTheBoss