fix: do not preseed slurm and slurmdbd configuration files #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
- No longer create empty slurm.conf file at installation. Instead the context manager will create an empty `SlurmConfig` object and make the new file the first time the admin sets a config value. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes preseeding an empty slurm.conf and slurmdbd.conf configuration file in the install hook. The slurm.conf file, specifically, would conflict with the slurm.conf file fetched from the Slurm controller
slurmctld. This caused issues if attempting to use slurm CLI commands as they would try to read the preseeded configuration file instead of the slurm.conf file underconf-cache.The configuration hooks now use the context manager provided by
slurmutilsto create the files on demand the first time their respective configuration hook is invoked.Fixes #27
Misc.
pyfakefsas test dependency. Context manager don't like being mocked, so I just created a fake file within the virtual filesystem instead 😅