This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat!: overhaul slurmd charm API #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
16d79c8 to
85e8200
Compare
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
2 times, most recently
from
b59de6b to
4cd40df
Compare
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
4cd40df to
773be3c
Compare
NucciTheBoss
suggested changes
Jun 18, 2024
|
Hey @jamesbeedy 👋 Could you please update this branch with the changes that you made to both the slurmdbd and slurmctld operators? Per our discussion yesterday during the Ubuntu HPC community call, we agreed that we would add some guardrails to the actions that enable administrators to modify the partition/node/slurm configuration. We can work on that in a follow-up pull request if that's good for you? |
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
773be3c to
2916b7d
Compare
* Improve the way slurmd sends slurmctld its node-config * Add an action, `node-config` to get and set unit level node-configuration * Add `partition-config` charm configuration that allows an operator to set partition configuration * Consolidate the yaml files into `charmcraft.yaml` * Remove unused code * Remove slurm-ops-manager * Replace nhc resource with nhc in build process in charmcraft.yaml * Remove dependencies on slurmdbd * rename interface slurmd -> slurmctld * update readme * remove fluentbit * replace machine.py with slurmd -C
NucciTheBoss
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
I'm ready to land this 🛬
Just some final nits, but those are things that I will commit as suggestions before merging. We can open subsequent pull requests to further refine various parts of the API, but overall I think this looks great for overhauling the Slurm charm API.
|
Great, lets do it. +1 from me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference the Slurm Charms Change Summary Document for an in-depth explanation of these changes.
These changes enhance the slurmd charm by:
slurmdsendsslurmctldits partition and node parameter optionsnode-configto get and set unit-level node-configurationpartition-configcharm configuration that allows an operator to setpartition configuration
charmcraft.yamlnhcresource with nhc in build process in charmcraft.yamlslurmdbdDepends on https://github.com/charmed-hpc/slurmctld-operator/pull/26/files