This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
fix: prime NHC tarball within charm during packing #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to add the part `charm: {}` to make the charm pack correctly.
jedel1043 and I found that this part declaration must be included in
`charmcraft.yaml`, or it will fail to pack the charm correctly.
nhc will be there, but the charm won't :'(
Signed-off-by: Jason C. Nucciarone <[email protected]>
Previously, if tar failed to extract the contents of the nhc tarball to `/tmp/nhc`, _install_nhc_from_tarball would throw an unhandled excepting that would cause the charm to bork. Now we catch if tar fails to extract the contents of the tarball, log the error output for the asministrator to read, and return False so that the slurmd operator can properly handle and install failure. Signed-off-by: Jason C. Nucciarone <[email protected]>
4 tasks
jamesbeedy
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
This checks out on my local build/deploy. Thanks @NucciTheBoss and @jedel1043 !
+1
jedel1043
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request properly primes the NHC tarball within the slurmd operator so that the operator will deploy correctly. It ensures that the NHC tarball is placed in
$CRAFT_PART_INSTALLso that it is eventually copied into the file artifact produced bycharmcraft pack.cc @jedel1043 helped with putting the initial patch together. After much boil and toil with discrepancies between our machines, we discovered that we needed to add
charm: {}to the parts definition in charmcraft.yaml to ensure that the charm would pack correctly. If we just specified NHC, only NHC would be put into the final charm, none of the magic charm sauce 😱How was the code tested?
Ran tests locally on my Ubuntu 24.04 workstation. Ensured that NHC was properly built during install hook execution.
Related issues and/or tasks
Fixes #36
Checklist