Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

fix: set `AuthAltTypes="auth/jwt" for jwt authentication #28

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jedel1043
Copy link
Contributor

@jedel1043 jedel1043 commented Jul 25, 2024

Description

This enables using slurmrestd to comunicate with slurmdbd.

How was the code tested?

Locally on an Ubuntu Noble development machine.

Checklist

  • I am the author of these changes, or I have the rights to submit them.
  • I have added the relevant changes to the README and/or documentation.
  • I have self reviewed my own code.
  • All requested changes and/or review comments have been resolved.

This enables using `slurmrestd` to comunicate with `slurmdbd`.
@NucciTheBoss NucciTheBoss self-requested a review July 25, 2024 17:02
@NucciTheBoss
Copy link
Member

@jedel1043 does this need to be against experimental or main?

Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering if this should instead be merged against experimental rather than main 🤔

@jedel1043
Copy link
Contributor Author

Main. This is also a bug on the main branch, but we probably haven't caught it since we aren't testing http requests against slurmrestd

@NucciTheBoss NucciTheBoss merged commit b304527 into charmed-hpc:main Jul 25, 2024
6 checks passed
@jedel1043 jedel1043 deleted the fix-jwt-auth branch July 25, 2024 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants