Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): release slurmutils version 0.7.0 #21

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

NucciTheBoss
Copy link
Member

This PR releases a new version of slurmutils. Changes this release include:

  1. Adding an editor for the cgroup.conf configuration file. This is needed for our slurm_ops charm library.
  2. Refactors how the data models are parsed and marshalled. Makes it easier for us to get the different configuration objects in their str representation for actions like juju run slurmctld/leader show-config.
  3. Fixes a grammatical error in the README.

Changes:

- Fixed a grammatical error in the slurmdbdconfig editor section.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss added the Type: Enhancement Proposes a new feature to be added to the project. label Sep 20, 2024
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I have a small nitpick about grammar and a thought that we could action on later.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Don't duplicate the header of each section but with only the configuration
file name changed. Instead, just have one header at the beginning that
states that the modules in this collection support editing the various
configuration files that Slurm has.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NucciTheBoss NucciTheBoss merged commit 7bc16d3 into charmed-hpc:main Sep 20, 2024
3 checks passed
@NucciTheBoss NucciTheBoss deleted the release branch October 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Proposes a new feature to be added to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants