Provide an override on the go version for eks snaps #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
akd/override-eks-go-version
branch
20 times, most recently
from
558ee29 to
35216a2
Compare
addyess
force-pushed
the
akd/override-eks-go-version
branch
from
35216a2 to
afc84f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Details
#1580 identified situations where the correct go version wasn't present when building the k8s snaps
This presents itself as a failed build of the eks snaps in certain cases.
Rather than change many branches, providing an override when building seemed like a saner option.