Fixing cmake charm++ and charm4py build with cuda #3836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, attempting to build with the cuda option using the cmake build resulted in the following error (on Delta):
The issue: the cuda library is referenced via the variable
CUDA
, and the cmake script introduces an option also namedCUDA
. This introduces confusion when cmake tries to find cuda:enable_language(CUDA)
.This PR fixes the issue by renaming the
CUDA
option asBUILD_CUDA
. The existing cmake structure requires that there still exists an option namedCUDA
for theconv-mach-cuda.h
discovery, so I pushed the creation of theCUDA
option to after all cuda library setup.This PR also links in the necessary cuda and HAPI libraries to charmlib.so, for use in charm4py.