allow craype for any targets (i.e., multicore) #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjbohm
requested review from
kavithachandrasekar,
matthiasdiener,
lvkale and
davidhardy
|
Would it be helpful to remove duplicate CMK_BUILD_CRAY=1 and CMK_CRAY_NOGNI=1 from files like arch/ofi-crayshasta/conv-mach.sh, arch/mpi-crayshasta/conv-mach.sh, arch/mpi-crayxc/conv-mach.sh and arch/mpi-crayxe/conv-mach.sh as part of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On newer machines with extensive layers of compilation (i.e,. delta-ai's grace/hopper supernodes) it can be difficult to build a proper binary using individual compiler targets. Our craype target delegates those issues to whatever the user has chosen within their craype module selection, but has previously been restricted to cray specific interconnect builds. There really isn't a good reason to do that. This change frees our craype wrapper for use with other targets, such as the multicore, or netlrts, builds.