validate that page parameters are deprecated

Signed-off-by: Bruno Vieira <[email protected]>

lib/chartmogul/errors/index.js

@@ -6,12 +6,14 @@ const ForbiddenError = require('./forbidden-error');
 const NotFoundError = require('./not-found-error');
 const ResourceInvalidError = require('./resource-invalid-error');
 const SchemaInvalidError = require('./schema-invalid-error');
+const InvalidParameterError = require('./invalid-parameter-error');
 
 module.exports = {
   ChartMogulError,
   ConfigurationError,
   ForbiddenError,
   NotFoundError,
   ResourceInvalidError,
-  SchemaInvalidError
+  SchemaInvalidError,
+  InvalidParameterError
 };

lib/chartmogul/errors/invalid-parameter-error.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const ChartMogulError = require('./chartmogul-error');
+
+class InvalidParameterError extends ChartMogulError {
+  constructor (message, httpStatus, response) {
+    super(message, httpStatus, response);
+    Error.captureStackTrace(this, this.constructor.name);
+  }
+}
+
+module.exports = InvalidParameterError;

lib/chartmogul/resource.js

@@ -45,6 +45,13 @@ class Resource {
         return reject(error);
       }
 
+      if (method === 'GET' && data && data.page !== undefined) {
+        const error = new errors.InvalidParameterError(
+          "Argument 'per_page' is deprecated"
+        );
+        return reject(error);
+      }
+
       const qs = method === 'GET' ? data : {};
       const body = method === 'GET' ? {} : data;
 

test/chartmogul/resource.js

@@ -10,6 +10,7 @@ const Customer = require('../../lib/chartmogul/customer');
 describe('Resource', () => {
   const config = new ChartMogul.Config('token');
   config.retries = 0; // no retry
+
   it('should send basicAuth headers', done => {
     nock(config.API_BASE)
       .get('/')
@@ -107,6 +108,19 @@ describe('Resource', () => {
         done();
       });
   });
+
+  it('should throw InvalidParameterError', done => {
+    nock(config.API_BASE)
+      .get('/customers?page=1')
+      .reply(200, '{}');
+
+    Customer.all(config, { page: 1 })
+      .then(res => done(new Error('Should throw error')))
+      .catch(e => {
+        expect(e).to.be.instanceOf(ChartMogul.ConfigurationError);
+        done();
+      });
+  });
 });
 
 describe('Resource Retry', () => {

test/chartmogul/subscription.js

@@ -89,7 +89,7 @@ describe('Subscription', () => {
         expect(res).to.have.property('subscriptions');
         expect(res.subscriptions).to.be.instanceof(Array);
         expect(res.cursor).to.eql('cursor==');
-        expect(res.has_more).to.eql(false)
+        expect(res.has_more).to.eql(false);
       });
   });
 });