-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in assertions returning true for some tests #100
Fix bug in assertions returning true for some tests #100
Conversation
This pull request has been linked to Shortcut Story #57880: Rewrite the assertion in Chartmogul Node library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test suite works (Tested locally)
package.json formatting can be reverted
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
…ttps://github.com/chartmogul/chartmogul-node into Fix-bug-in-assertions-returning-true-for-some-tests
Previous issues
Most of the existing tests were written incorrectly.
The
assertions
are inside a promise which does not return. Thetest
will always return true.Improvements Done
tests
which does not return anything were rewrittenAwait/async
used instead ofdone/done()
for deprecation error testsHow to properly test
To properly test;
For more context, here is the shortcut ticket
https://app.shortcut.com/chartmogul/story/57880/rewrite-the-assertion-in-chartmogul-node-library