add support for cursor pagination in supported endpoints #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #51956: [Node.js] Add support for new pagination to client libs. |
kmossco
force-pushed
the
sc-51956/add_support_for_cursor_pagination
branch
2 times, most recently
from
11bbc8b to
0a5ba94
Compare
kmossco
force-pushed
the
sc-51956/add_support_for_cursor_pagination
branch
2 times, most recently
from
3c18e14 to
95ed2c1
Compare
added 3 commits
September 14, 2023 15:32
Signed-off-by: Bruno Vieira <[email protected]>
Signed-off-by: Bruno Vieira <[email protected]>
Signed-off-by: Bruno Vieira <[email protected]>
kmossco
force-pushed
the
sc-51956/add_support_for_cursor_pagination
branch
from
95ed2c1 to
73730a7
Compare
added 2 commits
September 15, 2023 08:23
Signed-off-by: Bruno Vieira <[email protected]>
Signed-off-by: Bruno Vieira <[email protected]>
swember
approved these changes
Sep 19, 2023
daesu
approved these changes
Sep 27, 2023
|
Closing this for now, as the PR should now remove support for cursor pagination, and we have a ton of conflicts. Will open a new one very soon with the new logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added cursor based pagination to several of our API's endpoints this ensures the library supports that pagination. No need for code changes, but updated tests so we can ensure there is no regressions.