Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing customer_uuid when creating a note or retrieving all notes from a customer #87

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

SoeunSona
Copy link
Contributor

@SoeunSona SoeunSona commented Dec 20, 2023

Fix missing customer_uuid when creating a note or retrieving all notes from a customer

@SoeunSona SoeunSona force-pushed the soeunlee/missing_customer_uuid branch from b614875 to 2671aac Compare December 20, 2023 19:01
@SoeunSona SoeunSona marked this pull request as ready for review December 20, 2023 20:08
@SoeunSona SoeunSona requested review from briwa and kmossco December 20, 2023 20:08
const path = util.expandPath(CustomerNote.path, []);
return Resource.request(config, 'POST', path, { ...params, customerId }, callback);
return Resource.request(config, 'POST', path, { ...params, customer_uuid: customerId }, callback);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's a good idea to rename the variable for clarity

Suggested change
return Resource.request(config, 'POST', path, { ...params, customer_uuid: customerId }, callback);
return Resource.request(config, 'POST', path, { ...params, customer_uuid: customerUuid }, callback);

@SoeunSona SoeunSona merged commit af6272e into main Dec 21, 2023
4 checks passed
@SoeunSona SoeunSona deleted the soeunlee/missing_customer_uuid branch December 21, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants