feat(sc-57429): Support Opportunities API #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ticket: https://app.shortcut.com/chartmogul/story/57429/support-opportunities-resource-node-client
API Specs: https://www.notion.so/chartmogul/API-endpoints-for-Opportunities-a92323514bf44f89ad2f97ae30cee7f0#6f09cc7a71bc40e69ef65d8d0342d230
Background
There were added following methods to the library
Customers
Opportunities
Tests
Regarding the tests, you will be probably suprised about the other approach of tests, but I found out that all existing tests are incorrect for all the resources. Iwrote the tests for the opportunity in good way, but fixing all the others will take some time, so needs to be addressed independently. Will ping about it to the engineering channnel.
The issue is that we assert value in promise block with no return. This way the test will pass even though the assertion is false.