Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync docs with main chartmuseum repo #13

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

cbuto
Copy link
Collaborator

@cbuto cbuto commented Jan 30, 2022

Related to #9

For the most part this was copying the existing docs from https://github.com/helm/chartmuseum but I did take the opportunity to make some small adjustments! Let me know what you think

  1. I changed the background and text colors for code blocks, I had a hard time reading the dark blue text on the black background. The CSS changes make code blocks use white text with a black-ish background:

Screen Shot 2022-01-30 at 2 00 29 PM

If we want to stick with the dark blue, that's totally cool!

  1. I changed the Other CLI Options page to be All CLI Options. I was going to add some new CLI options to that existing page but it wasn't super easy to figure out what wasn't mentioned previously and get it formatted correctly. I just grabbed the output from chartmuseum -h and listed all the options. This will probably be easier to maintain down the line as well!

@cbuto cbuto requested review from jdolitsky and scbizu January 30, 2022 19:07
@cbuto cbuto self-assigned this Jan 30, 2022
Copy link
Collaborator

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible! Thanks so much @cbuto

@jdolitsky jdolitsky merged commit ee21baf into chartmuseum:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants