-
-
Notifications
You must be signed in to change notification settings - Fork 102
[WIP] Make sending of statistics into a setting #6851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hocuri
wants to merge
380
commits into
main
Choose a base branch
from
hoc/send-statistics-setting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hocuri <[email protected]>
Co-authored-by: Hocuri <[email protected]>
… group (#6905) I agree with holger that it's most important to allow communication in mixed/ambiguous groups, even if you can't modify the member list anymore. So, if any member of a group is in RESET peerstate, this downgrades the whole group to an Ad-Hoc group, rather than removing this member. Except for chatmail accounts, where we ignore the Reset state already before PGP-contacts, so, it's ignored in the migration, too. Broadcast lists keep the current behavior. Fix #6908
a4d64cb
to
5619601
Compare
Hocuri
added a commit
to deltachat/deltachat-android
that referenced
this pull request
Jun 25, 2025
Counterpart of chatmail/core#6851
285d80a
to
416131b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the statistics / self-reporting bot will be made into an opt-in regular sending of statistics, where you enable the setting once and then they will be sent automatically. The statistics will be sent to a bot, so that the user can see exactly which data is being sent, and how often. The chat will be archived and muted by default, so that it doesn't disturb the user.