Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iroh and remove iroh. subdomain #451

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Update iroh and remove iroh. subdomain #451

merged 1 commit into from
Nov 9, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Nov 5, 2024

Closes #445

@link2xt link2xt force-pushed the link2xt/update-iroh branch from d7ce5d9 to 98fd30e Compare November 5, 2024 13:50
@link2xt link2xt mentioned this pull request Nov 5, 2024
Open
@link2xt link2xt force-pushed the link2xt/update-iroh branch from 98fd30e to e54ee32 Compare November 5, 2024 14:59
@link2xt link2xt requested review from missytake and hpk42 November 5, 2024 15:02
@link2xt
Copy link
Contributor Author

link2xt commented Nov 5, 2024

This is ready. Previous deployment may want to acmetool unwant iroh.{domain}, but does not matter if they also keep a domain.

hpk42
hpk42 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@missytake
Copy link
Contributor

This is ready. Previous deployment may want to acmetool unwant iroh.{domain}, but does not matter if they also keep a domain.

we should add acmetool unwant iroh.{mail_domain} to __init__.py, at least for a while.

@link2xt link2xt merged commit 95f8c4b into main Nov 9, 2024
6 checks passed
@link2xt link2xt deleted the link2xt/update-iroh branch November 9, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpk42 hpk42 hpk42 approved these changes

@missytake missytake Awaiting requested review from missytake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iroh-relay does not work behind nginx proxy
3 participants
@link2xt @missytake @hpk42