Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement docker arm build (necessary for Pull Request #34) #37

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Implement docker arm build (necessary for Pull Request #34) #37

merged 3 commits into from
Mar 7, 2024

Conversation

jonded94
Copy link
Contributor

@jonded94 jonded94 commented Mar 1, 2024

This is a requirement for enabling Pull Request #34 to work.

  • Include build-docker.yml file for building the Docker container through CI
  • Enabled both Linux x86_64 and aarch64 builds.

@jonded94 jonded94 force-pushed the implement-docker-arm-build branch from 038d5a7 to ec66c52 Compare March 1, 2024 08:05
phoerious
phoerious approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phoerious phoerious merged commit 22f7816 into chatnoir-eu:develop Mar 7, 2024
12 checks passed
@jonded94 jonded94 mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoerious phoerious phoerious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonded94 @phoerious