Chore(maintenance)/refactor get user profile subscriptions #430 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed joins from user.service.ts getUserProfile with subscriptionUser and removed the getUserDto fields, the corresponding methods in serialize.ts, as well as the ISubscription interface
Added unittests for getUserProfile
Fixxed docker-compose for linux
5 tasks
|
Hey @leoseg just to say I've had a quick view over - thanks it looks good from what I can see! ⭐ I will do a proper review once the frontend ticket has been picked up and completed and I can see it all working together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #430
What changes did you make and why did you make them?
Removed joins from user.service.ts getUserProfile with subscriptionUser and removed the getUserDto fields, the corresponding methods in serialize.ts, as well as the ISubscription interface.
I also fixxed the docker-compose as was proposed in: #588.
Did you run tests? Share screenshot of results:
Until now only Unit-Tests as Frontend is not ready yet. So this merge request should not be merged until the blocked state from the issue is removed, and end2end tests with cypress run trough.
How did you find us? (GitHub, Google search, social media, etc.):
GitHub Open-Source for Good:)