-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource, resource Feedback and resource user modules #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far 🎉
src/utils/constants.ts
Outdated
@@ -52,6 +52,11 @@ export enum FEEDBACK_TAGS_ENUM { | |||
NOT_USEFUL = 'not useful', | |||
} | |||
|
|||
export enum RESOURCE_TYPE_ENUM { | |||
SHORT = 'short', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth making these more verbose, short_video, conversation_audio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that could work. Your call!
1628b7e
to
1394418
Compare
What changes did you make and why did you make them?
Adds new
Resource
ResourceFeedback
andResourceUser
entities, routes, controllers and services. Includes migration.These new content types are stored similar to the existing
Session
SessionFeedback
andSessionUser
setup.Refactors the storyblok webhook code to include updates to resources, and fixing previous bugs and repetition.
Cleans up incorrect database relationship definitions i.e.
JoinTable
is not required withOneToMany
.Cleans up use of
respository.create()
whererespository.save()
can be used.