Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource, resource Feedback and resource user modules #712

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

eleanorreem
Copy link
Contributor

@eleanorreem eleanorreem commented Nov 29, 2024

What changes did you make and why did you make them?

Adds new Resource ResourceFeedback and ResourceUser entities, routes, controllers and services. Includes migration.
These new content types are stored similar to the existing Session SessionFeedback and SessionUser setup.

Refactors the storyblok webhook code to include updates to resources, and fixing previous bugs and repetition.

Cleans up incorrect database relationship definitions i.e. JoinTable is not required with OneToMany.
Cleans up use of respository.create() where respository.save() can be used.

Copy link
Member

@annarhughes annarhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far 🎉

@@ -52,6 +52,11 @@ export enum FEEDBACK_TAGS_ENUM {
NOT_USEFUL = 'not useful',
}

export enum RESOURCE_TYPE_ENUM {
SHORT = 'short',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth making these more verbose, short_video, conversation_audio?

Copy link
Contributor Author

@eleanorreem eleanorreem Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that could work. Your call!

@annarhughes annarhughes marked this pull request as ready for review December 2, 2024 17:44
@annarhughes annarhughes merged commit a7bfb12 into develop Dec 3, 2024
4 checks passed
@annarhughes annarhughes deleted the resource-backend branch December 3, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants