Implement chdb v3.0.0 with pureGo instead of cGo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auxten now all the tests pass correctly. I will change also the readme and the documentation to reflect the new changes |
auxten
requested changes
Feb 16, 2025
|
|
||
| <a name="Session"></a> | ||
| ## type [Session](<https://github.com/chdb-io/chdb-go/blob/main/chdb/session.go#L11-L14>) | ||
| ## type [Session](<https://github.com/agoncear-mwb/chdb-go/blob/main/chdb/session.go#L15-L20>) |
| udfPath: "", | ||
| expectedErrMsg: "", | ||
| expectedResult: "123\n", | ||
| }, | ||
| // Session |
| @@ -51,52 +50,3 @@ func TestSessionCleanup(t *testing.T) { | |||
| t.Errorf("Session directory should be removed after Cleanup: %s", session.Path()) | |||
| } | |||
| } | |||
|
|
|||
| // TestQuery tests the Query method of the session. | |||
| func TestQuery(t *testing.T) { | |||
| } | ||
|
|
||
| // RawQuery will execute the given clickouse query without using any session. | ||
| func RawQuery(argc int, argv []string) (result ChdbResult, err error) { |
There was a problem hiding this comment.
The old connection less query C API should not co-exist with the connection based ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduce the base of the removal of
cGoin favor ofpureGo.Whit this approach, we can reduce the overhead that cGo introduce in the library.