Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'Restart Workspace' action #172

Merged

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Feb 6, 2023

Signed-off-by: Roman Nikitenko [email protected]

What does this PR do?

Adds an ability to restart a workspace directly from the IDE (no need to go to the dashboard).

What issues does this PR fix?

We need Restart Workspace action for the eclipse-che/che#18670

How to test this PR?

  1. Start a workspace
  2. Click on the Eclipse Che status bar item.
  3. Select Restart Workspace action.

Another way is:

  1. Press F1
  2. Type Restart Workspace
  3. Select Restart Workspace command.
Restart_Workspace.mp4

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Click here to review and test in web IDE: Contribute

@@ -3,5 +3,6 @@
"description": "Provides remoteIndicator commands",
"openDocumentationCommand": "Eclipse Che: Open Documentation",
"openDashboardCommand": "Eclipse Che: Open Dashboard",
"stopWorkspaceCommand": "Eclipse Che: Stop Workspace"
"stopWorkspaceCommand": "Eclipse Che: Stop Workspace",
"restartWorkspaceCommand": "Eclipse Che: Restart Workspace"
Copy link
Contributor Author

@RomanNikitenko RomanNikitenko Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding item should be added to this section to provide branding for the devspaces-code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to the Branding doc as well 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR to the devspaces-code: redhat-developer/devspaces-images#397

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR to the README file: #177

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-172-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-172-dev-amd64

@@ -53,7 +53,7 @@ export class CheDisconnectionHandler {
}

private restartWorkspaceHandler = () => {
this.devWorkspaceAssistant.restartWorkspace();
this.devWorkspaceAssistant.startWorkspace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the first glance, restartWorkspaceHandler is not consistent with startWorkspace()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed the handler,
thank you, Vitaliy!

Signed-off-by: Roman Nikitenko <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-172-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-172-dev-amd64

@RomanNikitenko RomanNikitenko merged commit 3e73e52 into che-incubator:main Feb 9, 2023
@RomanNikitenko RomanNikitenko deleted the restartWorkspaceAction branch February 9, 2023 08:05
@devstudio-release
Copy link

Build 3.6 :: code_3.x/366: Console, Changes, Git Data

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants