-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'Restart Workspace' action #172
feat: Add 'Restart Workspace' action #172
Conversation
Signed-off-by: Roman Nikitenko <[email protected]>
@@ -3,5 +3,6 @@ | |||
"description": "Provides remoteIndicator commands", | |||
"openDocumentationCommand": "Eclipse Che: Open Documentation", | |||
"openDashboardCommand": "Eclipse Che: Open Dashboard", | |||
"stopWorkspaceCommand": "Eclipse Che: Stop Workspace" | |||
"stopWorkspaceCommand": "Eclipse Che: Stop Workspace", | |||
"restartWorkspaceCommand": "Eclipse Che: Restart Workspace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding item should be added to this section to provide branding for the devspaces-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to the Branding doc as well 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR to the devspaces-code
: redhat-developer/devspaces-images#397
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR to the README file: #177
Pull Request images published ✨ |
@@ -53,7 +53,7 @@ export class CheDisconnectionHandler { | |||
} | |||
|
|||
private restartWorkspaceHandler = () => { | |||
this.devWorkspaceAssistant.restartWorkspace(); | |||
this.devWorkspaceAssistant.startWorkspace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the first glance, restartWorkspaceHandler
is not consistent with startWorkspace()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed the handler,
thank you, Vitaliy!
Signed-off-by: Roman Nikitenko <[email protected]>
Pull Request images published ✨ |
Build 3.6 :: code_3.x/366: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2333: Console, Changes, Git Data |
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
Adds an ability to restart a workspace directly from the IDE (no need to go to the dashboard).
What issues does this PR fix?
We need
Restart Workspace
action for the eclipse-che/che#18670How to test this PR?
Eclipse Che
status bar item.Restart Workspace
action.Another way is:
F1
Restart Workspace
Restart Workspace
command.Restart_Workspace.mp4