-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support 2.3.0 Devfile #386
Conversation
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-386-amd64 |
dependencies: | ||
"@devfile/api" "2.2.2-1700686170" | ||
axios "1.6.0" | ||
"@devfile/api" "2.2.2-1715367693" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. why not 2.3.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a transitive dependency
it means that [email protected]
depends on devfile/api" "2.2.2-1715367693
so - the answer on the che-devworkspace-generator
side
I'm not sure, but probably it should have been changed within eclipse-che/che-devfile-registry#828
@vinokurig could you share your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the patch according to the provided steps (thx Roman for preparing it) and I can confirm the patch closes eclipse-che/che#23038 by adding support for Devfile 2.3.0
Thanks @RomanNikitenko for fixing it 👍
Build 3.16 :: code_3.x/1435: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7185: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4734: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7164: code : 3.x :: Build 62632843 : quay.io/devspaces/code-rhel8:3.16-4 |
Build 3.16 :: update-digests_3.x/7044: Console, Changes, Git Data |
Build 3.16 :: code_3.x/1435: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7185 triggered |
Build 3.16 :: operator-bundle_3.x/3280: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7187: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7166: devspaces-operator-bundle : 3.x :: Failed in 62642442 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
che-devworkspace-generator
dependency version to get 2.3.0 Devfile supportaxios
version asche-devworkspace-generator
requires1.7.0
axios (there is a compilation problem for1.6.0
axios)What issues does this PR fix?
eclipse-che/che#23038
How to test this PR?
Create Workspace
pageschemaVersion: 2.3.0
Git repo URL
=> sethttps://github.com/RomanNikitenko/web-nodejs-sample/tree/test-2-3-0-devfile
F1
=>Restart Workspace from Local Devfile
Expected behaviour:
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder==========================================
Signed-off-by: Roman Nikitenko [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED