Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support 2.3.0 Devfile #386

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Jul 15, 2024

What does this PR do?

  • update che-devworkspace-generator dependency version to get 2.3.0 Devfile support
  • update axios version as che-devworkspace-generator requires 1.7.0 axios (there is a compilation problem for 1.6.0 axios)

What issues does this PR fix?

eclipse-che/che#23038

How to test this PR?

  • Go to the dashboard =>Create Workspace page
  • Create a workspace from a devfile with schemaVersion: 2.3.0
  • You can use my sample: Git repo URL => set https://github.com/RomanNikitenko/web-nodejs-sample/tree/test-2-3-0-devfile
  • Provide any changes to the devfile
  • F1 => Restart Workspace from Local Devfile

Expected behaviour:

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

==========================================
Signed-off-by: Roman Nikitenko [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

github-actions bot commented Jul 15, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: Roman Nikitenko <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

@RomanNikitenko RomanNikitenko marked this pull request as ready for review July 15, 2024 16:40
@ibuziuk ibuziuk self-requested a review July 16, 2024 09:50
dependencies:
"@devfile/api" "2.2.2-1700686170"
axios "1.6.0"
"@devfile/api" "2.2.2-1715367693"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. why not 2.3.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a transitive dependency
it means that [email protected] depends on devfile/api" "2.2.2-1715367693
so - the answer on the che-devworkspace-generator side

I'm not sure, but probably it should have been changed within eclipse-che/che-devfile-registry#828
@vinokurig could you share your opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that even 7.88.0-next-b9db1cf version that was published 4 hours ago - brings "@devfile/api" "2.2.2-1716821574", not 2.3.0

image image

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the patch according to the provided steps (thx Roman for preparing it) and I can confirm the patch closes eclipse-che/che#23038 by adding support for Devfile 2.3.0

image

Thanks @RomanNikitenko for fixing it 👍

@RomanNikitenko RomanNikitenko merged commit d27551f into main Jul 16, 2024
6 of 7 checks passed
@RomanNikitenko RomanNikitenko deleted the fix-restart-from-local-devfile-2-3-0 branch July 16, 2024 11:04
@devstudio-release
Copy link

Build 3.16 :: code_3.x/1435: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@RomanNikitenko RomanNikitenko mentioned this pull request Jul 16, 2024
3 tasks
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: code_3.x/1435: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7185 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/7166: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62642442 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants