Added border-radius support #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…radius values and add blockify method to Style class for block display handling.
- Introduced a new layout system specification document detailing the Dropflow layout engine, including core components, layout processes, and border drawing integration. - Added a .prettierignore file to exclude all project files from formatting. - Created a new examples.js file containing various HTML examples to demonstrate layout capabilities, including typography, grid layout, and box layout with different border styles. - Updated index.html and index.js to integrate the examples and enhance the user interface with a toolbar for selecting examples.
- Updated the BoxBorder interface to use ComputedBorderRadius for corner radius values, improving type consistency. - Introduced a new hasBorderRadius function to determine if a border has a radius based on its properties. - Refactored paintFormattingBoxBackground to utilize the new hasBorderRadius function for better clarity and efficiency. - Modified CSS parsing rules to replace LENGTH with length_side for border radius properties, ensuring accurate parsing of side lengths. - Adjusted style definitions to align with the new ComputedBorderRadius type for better integration across the codebase.
- Renamed "Typography Showcase" to "Typography Tests" for clarity. - Enhanced typography section with detailed font weights, styles, and semantic elements. - Improved text examples to include various text decorations and styles for better demonstration of capabilities.
- Updated the border-radius parsing rules to support both horizontal and vertical radius values, allowing for more flexible CSS definitions. - Introduced helper functions for expanding radius values and handling slash-separated radius lists. - Refactored related functions to improve clarity and maintainability, ensuring consistent handling of border radius properties across the codebase.
- Bump version from 0.5.1 to 0.6.0 in package-lock.json. - Update @ddietr/codemirror-themes dependency to version 1.5.1. - Add @types/codemirror and @types/tern as new dev dependencies. - Change import statements in box-border.ts to use type imports for better clarity. - Remove unnecessary border radius object in paint.ts to streamline code.
BobPritchett
force-pushed
the
master
branch
from
d1ab087 to
f63d0a5
Compare
- Updated the handling of percentage values for border-radius to calculate horizontal and vertical radii based on the box's border area, improving accuracy. - Simplified the resolveEm function to handle percentage units more effectively, ensuring consistent unit resolution across styles.
|
I would love to have this. It's a bit hard to review right now because there are so many changes unrelated to border-radius. I'd suggest first removing Then you could remove the formatting changes. You might I'll leave a review of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for most borders (solid, dashed, dotted, double) and border-radius values.
Enhanced the index.html test harness with multiple samples.
Open issues: