Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated eslint-plugin-sonarjs #178

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Updated eslint-plugin-sonarjs #178

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
675ba08
Updated eslint-plugin-sonarjs
jpolavar Oct 24, 2024
6819ac5
Updated eslint-plugin-sonarjs
jpolavar Oct 24, 2024
bb10cc3
Pinned eslint-plugin-sonarjs to the latest version
jpolavar Oct 24, 2024
d0094c8
merged conflicts
jpolavar Oct 29, 2024
5ae4c09
Merged changes from main
jpolavar Dec 25, 2024
86c5227
Merged changes from main
jpolavar Dec 25, 2024
f84addd
Merged changes from main
jpolavar Dec 25, 2024
c1bf3d2
Merged changes from main
jpolavar Dec 25, 2024
ee15c52
Updated to latest sonarjs i.e v3
jpolavar Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ const tsConfigurations = [
// typeof any === "evil".
'@typescript-eslint/no-explicit-any': 'error',

'sonarjs/no-empty-function': 'off',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder why these 2 rules are disabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like v3 doesn't worry about about empty function, unused expression and this was earlier added to handle eslint error in index.ts

'sonarjs/no-unused-expressions': 'off',
// We're smarter than the default (15). Right?
'sonarjs/cognitive-complexity': ['error', 24],
'no-only-tests/no-only-tests': 'error',
Expand Down
Loading
Loading