Skip to content

Conversation

ferrandiaz
Copy link
Contributor

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  1. Allow passing playwright config path at a check level
  2. if no config path is provided at check level fallback to general config path
  3. If no config path is provided, fail.

This also allows the user not to define a playwrightConfigPath at the top level and just define them at check level if they want.

@ferrandiaz ferrandiaz requested a review from sorccu October 2, 2025 10:01
@sorccu sorccu force-pushed the ferran/tra-1497-add-playwrightconfigpath-per-pw-check-definition branch from 61082f9 to 52596dd Compare October 6, 2025 07:43
@sorccu sorccu force-pushed the ferran/tra-1497-add-playwrightconfigpath-per-pw-check-definition branch from de61645 to 0e16f87 Compare October 6, 2025 10:09
Copy link
Member

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a cleanup at some point but it'll do for now.

@sorccu sorccu merged commit 7bd5d2a into main Oct 6, 2025
5 of 6 checks passed
@sorccu sorccu deleted the ferran/tra-1497-add-playwrightconfigpath-per-pw-check-definition branch October 6, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants