Skip to content

Conversation

maxigimenez
Copy link
Member

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add Playwright checks examples

name: 'Playwright tests',
use: {
...devices['Desktop Chrome'],
userAgent: `${devices['Desktop Chrome'].userAgent} (Checkly, https://www.checklyhq.com)`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxigimenez @MariadeAnton Is this something we recommend people to do? If we ship this in the general boilerplate we should highlight in the docs, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxigimenez maxigimenez marked this pull request as ready for review October 7, 2025 08:20
@maxigimenez
Copy link
Member Author

@sorccu this change 2858a8f fixed the create-cli issue from #1097 (comment)

"checkly": "latest",
"jiti": "^2"
"jiti": "^2",
"@playwright/test": "1.55.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least change this to ^1.55.1 to make the version more flexible? Or just ^1 like we do for jiti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants