-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add playwright check examples [kit-2234] #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add playwright check examples [kit-2234] #1156
Conversation
name: 'Playwright tests', | ||
use: { | ||
...devices['Desktop Chrome'], | ||
userAgent: `${devices['Desktop Chrome'].userAgent} (Checkly, https://www.checklyhq.com)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxigimenez @MariadeAnton Is this something we recommend people to do? If we ship this in the general boilerplate we should highlight in the docs, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanjudis https://www.checklyhq.com/docs/platform/allowlisting-traffic/#allowlisting-playwright-checks-with-user-agents, we are adjusting the docs still btw
@sorccu this change 2858a8f fixed the create-cli issue from #1097 (comment) |
"checkly": "latest", | ||
"jiti": "^2" | ||
"jiti": "^2", | ||
"@playwright/test": "1.55.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least change this to ^1.55.1
to make the version more flexible? Or just ^1
like we do for jiti
.
Affected Components
Notes for the Reviewer
Add Playwright checks examples