chore: replace ancient tunnel + proxy-from-env with proxy-agent
#1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
force-pushed
the
simo/sim-138-cli-replace-7-year-told-tunnel-package-with-proxy-agent
branch
from
65fa143 to
70d8793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This PR currently has an issue where the proxy server port gets attached to port-lacking destination URLs. So,
https://api.checklyhq.combecomeshttps://api.checklyhq.com:8080ifhttps_proxy=http://localhost:8080, for example.The
tunnelpackage we use has not been updated for 7 years and it's a bit unclear if it still does what it's supposed to in recent Node versions. I was having some trouble getting MITM to work today and rather than diving deep into an ancient package, I figured we should update to something more modern.This change is better for security, and potentially enables new types of proxy-reliant setups with no effort from our side.
Affected Components
Notes for the Reviewer
New Dependency Submission