This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
fix to work with new amazon design #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnolet
suggested changes
Feb 5, 2020
| @@ -7,16 +7,18 @@ const puppeteer = require('puppeteer') | |||
| const screenshot = 'amazon_nyan_cat_pullover.png' | |||
| try { | |||
| (async () => { | |||
| const browser = await puppeteer.launch() | |||
| const browser = await puppeteer.launch({ headless: false}) | |||
There was a problem hiding this comment.
We want to have { headless: true } here
| const page = await browser.newPage() | ||
| await page.setViewport({ width: 1280, height: 800 }) | ||
| await page.goto('https://www.amazon.com') | ||
| await page.type('#twotabsearchtextbox', 'nyan cat pullover') | ||
| await page.click('input.nav-input') | ||
| await page.waitForSelector('#resultsCol') | ||
| await page.waitFor(3000); |
There was a problem hiding this comment.
This is an anti-pattern. waitFor(3000) or any wait period that does not wait for an explicit element is bound to break. Please wait for a specific element.
| await page.click('#pagnNextString') | ||
| await page.waitForSelector('#resultsCol') | ||
| await page.click('li[class="a-last"] > a') | ||
| await page.waitFor(3000); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.