Update DNS Merchant regular expression length (#431)

checkout · Aug 29, 2024 · a98e2bb · a98e2bb
1 parent e6f8d76
commit a98e2bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/checkout/EnvironmentSubdomain.java b/src/main/java/com/checkout/EnvironmentSubdomain.java
@@ -25,7 +25,7 @@ private static URI addSubdomainToApiUrlEnvironment(IEnvironment environment, Str
         } catch (final URISyntaxException e) {
             throw new CheckoutException(e);
         }
-        Pattern pattern = Pattern.compile("^[0-9a-z]{8,11}$");
+        Pattern pattern = Pattern.compile("^[0-9a-z]+$");
         Matcher matcher = pattern.matcher(subdomain);
         if (matcher.matches()) {
             String host = apiUrl.getHost();

diff --git a/src/test/java/com/checkout/DefaultCheckoutConfigurationTest.java b/src/test/java/com/checkout/DefaultCheckoutConfigurationTest.java
@@ -47,7 +47,7 @@ void shouldCreateConfiguration() {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = {"123dmain", "123domain", "1234domain", "12345domain"})
+    @ValueSource(strings = {"a", "ab", "abc", "abc1", "12345domain"})
     void shouldCreateConfigurationWithSubdomain(String subdomain) {
 
         final StaticKeysSdkCredentials credentials = Mockito.mock(StaticKeysSdkCredentials.class);
@@ -58,7 +58,7 @@ void shouldCreateConfigurationWithSubdomain(String subdomain) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = {"", "123", "123bad", "12345domainBad"})
+    @ValueSource(strings = {"", " ", "  ", " - ", "a b", "ab c1"})
     void shouldCreateConfigurationWithBadSubdomain(String subdomain) {
 
         final StaticKeysSdkCredentials credentials = Mockito.mock(StaticKeysSdkCredentials.class);