-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Transport Configuration support #373
Custom Transport Configuration support #373
Conversation
Please @dlabey review all the tests, some test are failing |
@armando-rodriguez-cko because I am on a fork I am not inheriting the IT secrets from the GitHub environment, and the tests have hardcoded processing channels... how do you advise I proceed? |
@armando-rodriguez-cko I changed the build-pull-request file to use pull_request_target so it inherits the context of the source repo. According to https://blog.gitguardian.com/github-actions-security-cheat-sheet/, this can be insecure unless you manually approve the execution of workflows, which you are doing, so maybe this will help. |
Hi @dlabey, thank you for the changes but we can't admit the last commit, as you say this change is insecure. We will pass the tests with your previous changes and tell you how to proceed. Thank you. |
…ext of the source repo" This reverts commit 930fbe8.
@armando-rodriguez-cko I have merged it back, could you checkout this branch and run it with the secrets locally? Or could you take this branch and put it into the checkout owned repo for a PR to inherit the secrets? |
@armando-rodriguez-cko any update? I cannot run the IT properly because my fork does not inherit the IT Checkout API keys which are coupled to the processing channels used in the IT tests... |
Hi @dlabey, we are working on it, sorry by the delay, we will try to finish it today. |
Fixes #372