Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates in properties, APMs and Disputes endpoint #451

Merged

Conversation

armando-rodriguez-cko
Copy link
Contributor

Description

This PR introduces enhancements to support additional payment methods, streamline dispute management, and refactor existing models for improved maintainability and functionality.

Changes Made

Payment Methods (APMs):

  • Added support for new APMs, including:
    • Bizum, Plaid, Octopus, Sequra, and Tabby.
  • Updated PaymentPlan to use AmountVariabilityType for more precise handling of payment plan variability.
  • Introduced new payment source request and response classes to accommodate these APMs.

Disputes:

  • Enhanced dispute handling with new features:
    • Added arbitration-related properties and methods, such as submitArbitrationEvidence and getCompiledSubmittedArbitrationEvidence.
    • Introduced models like CompellingEvidence, EvidenceBundle, EvidenceList, and HistoricalTransactions to manage evidence more effectively.
    • Supported additional dispute statuses and relevant evidence types.
  • Updated DisputesClient and its implementation to accommodate these changes.

Refactoring AccountHolder Model:

  • Refactored AccountHolder into a modular structure:
    • Introduced AccountHolderBase to manage shared properties.
    • Added AccountHolderResponse and AccountNameInquiryType for enhanced account holder management.
  • Simplified model inheritance to ensure extensibility.

Unit Tests:

  • Added tests for new payment methods and dispute-related functionalities.
  • Covered edge cases, such as incomplete or invalid API responses.
  • Verified backward compatibility and ensured proper integration of new features.

General Improvements:

  • Removed redundant code and optimized existing logic in serializers and deserializers.
  • Consolidated common functionality across payment sources and dispute handling.
  • Improved test coverage and reliability of SDK functionality.

Impact

  • Improved functionality: Expands SDK capabilities by supporting more payment methods and robust dispute handling.
  • Enhanced maintainability: Modular design and refactoring improve code readability and future scalability.
  • Increased reliability: Better error handling and unit test coverage ensure a more stable experience for SDK users.

Additional Notes

  • Fully backward compatible with existing implementations.
  • Ensures smoother integrations for merchants adopting new payment methods and arbitration workflows.

@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team December 3, 2024 10:21
@armando-rodriguez-cko armando-rodriguez-cko merged commit c6cf94e into master Dec 3, 2024
4 checks passed
@armando-rodriguez-cko armando-rodriguez-cko deleted the feature/INT-1530-INT-1518-INT-1520-INT-1529 branch December 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants