Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIMOB-2183: Add github actions for linting and unit testing #240

Merged
merged 17 commits into from
Oct 10, 2023
Merged

PIMOB-2183: Add github actions for linting and unit testing #240

merged 17 commits into from
Oct 10, 2023

Conversation

jheng-hao-lin-cko
Copy link
Contributor

@jheng-hao-lin-cko jheng-hao-lin-cko commented Oct 5, 2023 •
edited
Loading

Issue

PIMOB-2198

Proposed changes

Add GHA flows for the following

  • Build
  • Lint
  • Unit tests

Test Steps

This PR should have a execute the following properly

  • lint
  • unit tests

Checklist

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes

Further Comments

We will clean up the duplicated steps in Bitrise once we have a higher confidence GHA migration is done well and completely.

@jheng-hao-lin-cko jheng-hao-lin-cko added the enhancement New feature or request label Oct 5, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko self-assigned this Oct 5, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-2183-migrated_to_GHA branch from f5216ce to fdee103 Compare October 6, 2023 12:56
@jheng-hao-lin-cko jheng-hao-lin-cko mentioned this pull request Oct 10, 2023
Merged
5 tasks
@jheng-hao-lin-cko jheng-hao-lin-cko changed the title PIMOB-2183: Add github actions and remove duplicated steps from bitrise.yml PIMOB-2183: Add github actions for Linting and Uniting and remove duplicated steps from bitrise.yml Oct 10, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko changed the title PIMOB-2183: Add github actions for Linting and Uniting and remove duplicated steps from bitrise.yml PIMOB-2183: Add github actions for linting and unit testing Oct 10, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as ready for review October 10, 2023 12:30
@jheng-hao-lin-cko jheng-hao-lin-cko requested a review from a team as a code owner October 10, 2023 12:30
fabio-insolia-cko
fabio-insolia-cko approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@fabio-insolia-cko fabio-insolia-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and here there are a couple of articles on how we can have a cleaner approach by creating reusable and dependent jobs, however the task here is done and achieved so I am happy to approve it

@jheng-hao-lin-cko jheng-hao-lin-cko merged commit aeff594 into master Oct 10, 2023
7 of 8 checks passed
@jheng-hao-lin-cko jheng-hao-lin-cko deleted the feature/PIMOB-2183-migrated_to_GHA branch October 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabio-insolia-cko fabio-insolia-cko fabio-insolia-cko approved these changes

@chintan-soni-cko chintan-soni-cko chintan-soni-cko approved these changes

Assignees

@jheng-hao-lin-cko jheng-hao-lin-cko

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jheng-hao-lin-cko @chintan-soni-cko @fabio-insolia-cko