Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIMOB-2183: Update KtLint version and .editorconfig & run ktlintFormat #242

Merged
merged 2 commits into from
Oct 10, 2023
Merged

PIMOB-2183: Update KtLint version and .editorconfig & run ktlintFormat #242

merged 2 commits into from
Oct 10, 2023

Conversation

jheng-hao-lin-cko
Copy link
Contributor

@jheng-hao-lin-cko jheng-hao-lin-cko commented Oct 9, 2023 •
edited
Loading

Issue

PIMOB-2183

Proposed changes

  • Update KtLint version to 0.50.0
  • Update .editorconfig to align with other Android repos
  • Run ktlintFormat to autoformat against the .editorconfig
  • Rename showAlertDialog to Extensions to fit the ktlint style

Test Steps

Run ktlint locally and pass. No functionality changed.

Checklist

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes

@jheng-hao-lin-cko jheng-hao-lin-cko added the enhancement New feature or request label Oct 9, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko self-assigned this Oct 9, 2023
@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as ready for review October 9, 2023 17:37
@jheng-hao-lin-cko jheng-hao-lin-cko requested a review from a team as a code owner October 9, 2023 17:37
@jheng-hao-lin-cko jheng-hao-lin-cko mentioned this pull request Oct 10, 2023
Merged
5 tasks
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-2183-run_ktlintFormat branch from 1ccf549 to ae2efb2 Compare October 10, 2023 12:58
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-2183-run_ktlintFormat branch from ae2efb2 to 8e26e60 Compare October 10, 2023 16:06
chintan-soni-cko
chintan-soni-cko approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@chintan-soni-cko chintan-soni-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jheng-hao-lin-cko jheng-hao-lin-cko merged commit 9013c4a into master Oct 10, 2023
7 of 8 checks passed
@jheng-hao-lin-cko jheng-hao-lin-cko deleted the feature/PIMOB-2183-run_ktlintFormat branch October 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chintan-soni-cko chintan-soni-cko chintan-soni-cko approved these changes

Assignees

@jheng-hao-lin-cko jheng-hao-lin-cko

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jheng-hao-lin-cko @chintan-soni-cko