Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/PIMOB-2943_Create_SNAPSHOT_version_with_compose_update_fix #284

Conversation

fabio-insolia-cko
Copy link
Contributor

@fabio-insolia-cko fabio-insolia-cko commented Oct 23, 2024

Issue

PIMOB-2943

Proposed changes

  • Upgrading compose from 1.5.3 to 1.7.4
  • Updating the lint-baseline files

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

since we rely on github for our release process we will proceed to create the beta/SNAPSHOT once this PR is merged, unless anyone can suggest a better approach

@fabio-insolia-cko fabio-insolia-cko self-assigned this Oct 23, 2024
@fabio-insolia-cko fabio-insolia-cko requested a review from a team as a code owner October 23, 2024 10:29
@fabio-insolia-cko fabio-insolia-cko marked this pull request as draft October 23, 2024 11:54
feature/PIMOB-2943_Create_SNAPSHOT_version_with_compose_update_fix
@fabio-insolia-cko fabio-insolia-cko force-pushed the feature/PIMOB-2943_Create_SNAPSHOT_version_with_compose_update_fix branch from 081c02f to 5d48fb7 Compare October 24, 2024 08:22
@fabio-insolia-cko fabio-insolia-cko marked this pull request as ready for review October 24, 2024 08:51
@chintan-soni-cko
Copy link
Contributor

@fabio-insolia-cko. Currently, the java based app crashing fetching this branch and running the sample app. Can we validate it after updating compose version. So, it will not impact the existing Frames merchant who are not using compose.
Screenshot 2024-10-24 at 10 24 05

@fabio-insolia-cko
Copy link
Contributor Author

@fabio-insolia-cko. Currently, the java based app crashing fetching this branch and running the sample app. Can we validate it after updating compose version. So, it will not impact the existing Frames merchant who are not using compose. Screenshot 2024-10-24 at 10 24 05

fixed by adding id("org.jetbrains.kotlin.android") to the app build.gradle file

@fabio-insolia-cko fabio-insolia-cko merged commit a2677df into master Oct 25, 2024
24 checks passed
@fabio-insolia-cko fabio-insolia-cko deleted the feature/PIMOB-2943_Create_SNAPSHOT_version_with_compose_update_fix branch October 25, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants