Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMOB:3162 - Add token_format for Googlepay token #290

Merged

Conversation

chintan-soni-cko
Copy link
Contributor

@chintan-soni-cko chintan-soni-cko commented Jan 14, 2025

Issue

PIMOB-3162
Reference ticket for Tier 1 merchant

Proposed changes

  1. Add missing fields token_format for Google pay. Api reference
  2. Updated and refactored unit tests

Note

Currently, keys are deprecated. Ticket is in the backlog. So, whenever testing it use Flow Sandbox keys for now manually.

Test Steps

Manual testing:
For Gpay tokenisation response validate value for token_format from onSucces callback which returning TokenDetails

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

@chintan-soni-cko chintan-soni-cko self-assigned this Jan 14, 2025
@chintan-soni-cko chintan-soni-cko marked this pull request as ready for review January 14, 2025 12:36
@chintan-soni-cko chintan-soni-cko requested a review from a team as a code owner January 14, 2025 12:36
@chintan-soni-cko chintan-soni-cko force-pushed the feature/PIMOB-3162_add_token_format_field_for_gpay branch from bacc0a2 to c22b40f Compare January 14, 2025 14:14
@chintan-soni-cko chintan-soni-cko changed the title PIMOB:3162 - Add token_format for Googlepay token and updating keys PIMOB:3162 - Add token_format for Googlepay token Jan 14, 2025
@chintan-soni-cko chintan-soni-cko force-pushed the feature/PIMOB-3162_add_token_format_field_for_gpay branch from c22b40f to 4e8f7b0 Compare January 14, 2025 14:20
@chintan-soni-cko chintan-soni-cko merged commit 0251b0d into master Jan 15, 2025
24 checks passed
@chintan-soni-cko chintan-soni-cko deleted the feature/PIMOB-3162_add_token_format_field_for_gpay branch January 15, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants