Issue #17756: Fix GenericWhitespaceCheck to reject tabs after '>'

[DakshRJain737]

Fixes GenericWhitespaceCheck to reject tab characters after closing angle bracket '>'
and enforce a single ASCII space where required, while keeping existing diamond operator exceptions intact.

This resolves Issue #17756.

[mohitsatr]

@DakshRJain737 you need to add test cases to prove your code actually resolves the issue.
Make a input file, copy the code from the issue and test if false-negative is actually eliminated.

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java

Line 45 in ec16b48

public class GenericWhitespaceCheckTest

[DakshRJain737]

@mohitsatr I used tab space in input file. Its not being approved by workflows due to the tab

[mohitsatr]

@DakshRJain737 Tabs are not allowed. Use Spaces

[DakshRJain737]

@mohitsatr tried what you told but i dont know why it feels messed up

[DakshRJain737]

@mohitsatr

here after + 1 < line.length can never be false due to which missed branches coverage is stuck at 93%

[mohitsatr]

Github, generate report for GenericWhitespace/all-examples-in-one

[github-actions]

Report for GenericWhitespace/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/index.html

[mohitsatr]

@DakshRJain737

Add the following cases/ or similar looking syntax to the input:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/apache-ant/xref/home/runner/work/checkstyle/checkstyle/.ci-temp/repositories/apache-ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java.html#L47

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/apache-ant/xref/home/runner/work/checkstyle/checkstyle/.ci-temp/repositories/apache-ant/src/main/org/apache/tools/ant/types/PropertySet.java.html#L281

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/elasticsearch/xref/home/runner/work/checkstyle/checkstyle/.ci-temp/repositories/elasticsearch/src/main/java/org/elasticsearch/index/mapper/FieldMapperListener.java.html#L41

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/checkstyle/xref/home/runner/work/checkstyle/checkstyle/.ci-temp/repositories/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationMembers.java.html#L90

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/918c1787f4bf07c673cecff7a50bd91d3224aa15_2025120649/reports/diff/checkstyle/xref/home/runner/work/checkstyle/checkstyle/.ci-temp/repositories/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationFromGuava.java.html#L21

and see if branch is fully covered after adding them

[mohitsatr]

items:

[DakshRJain737]

@mohitsatr 100% code coverage
I think the problem is with my src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/InputGenericWhitespace.java
bacause the line is too long
line 18
line 20 and
line 26

[DakshRJain737]

@mohitsatr sir 🙂
I am really sorry for troubling you so much.

[DakshRJain737]

[ERROR] AdvancedNetworkAddressPicker.java:87:56: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] AdvancedNetworkAddressPicker.java:97:56: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] AdvancedNetworkAddressPicker.java:112:56: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] MapProxyImpl.java:826:22: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] TypedByteArrayDeserializer.java:26:46: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] TypedStreamDeserializer.java:28:43: '>' is followed by an illegal character. [GenericWhitespace]
[ERROR] ClientMapBasicTest.java:911:29: '>' is followed by an illegal character. [GenericWhitespace]

I just saw the hazelcast repo and the code in AdvancedNetworkAddressPicker.java:87:56: has multiple space after '>'.

[mohitsatr]

I just saw the hazelcast repo and the code

Please raise a PR on their project, fixing the spaces in all these files and reference this PR in the description. Example: pgjdbc/pgjdbc#3682

[DakshRJain737]

@mohitsatr Oh done I will do it by today
Btw there are two pitest issue I can see

[mohitsatr]

I think something went wrong with pitest CI workflow itself. It did not fail last time. don't worry It is not failing because of your code.

[DakshRJain737]

I think something went wrong with pitest CI workflow itself. It did not fail last time. don't worry It is not failing because of your code.

Ok I will resolve hazelcast issue by today