Skip to content

Commit

Permalink
uups
Browse files Browse the repository at this point in the history
  • Loading branch information
skatkov committed Sep 26, 2024
1 parent e77b07d commit 1d6953d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
4 changes: 0 additions & 4 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ appraise "rails-7-0" do
gem "rails", "~> 7.0.0"
end

appraise "rails-7-1" do
gem "rails", "~> 7.1.0"
end

appraise "rails-7-2" do
gem "rails", "~> 7.2.0"
end
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
PBBuilder generates [Protobuf](https://developers.google.com/protocol-buffers) Messages with a simple DSL similar to the [JBuilder](https://rubygems.org/gems/jbuilder) gem.

## Requirements
This gem only supports Rails 7.0 annd Rails 7.2, **7.1 is not supported**.
This gem only supports Rails 7.0 and Rails 7.2, **7.1 is not supported**.

There currently is a regression in ActionView (the part of Rails which renders) that forces rendered objects into strings, but for Pbbuilder we need the raw objects.
This is only present in Rails 7.1, and a fix is released in Rails 7.2. https://github.com/rails/rails/pull/51023

It might work on rails v6, but we don't guarantee that.
It might work on rails v6 (it worked previously), but we don't guarantee that and don't test against these versions anymore.

## Compatibility with jBuilder
We don't aim to have 100% compitability and coverage with jbuilder gem, but we closely follow jbuilder's API design to maintain familiarity.
Expand Down
9 changes: 0 additions & 9 deletions gemfiles/rails_7_1.gemfile

This file was deleted.

0 comments on commit 1d6953d

Please sign in to comment.