Drop support for rails v6.* versions (#60)

The nio4j dependency requires compilation for 6 versions of Rails. For me compilation fails, while version 7 works great. I propose we discontinue testing on Rails 6.x branches. Rails team no longer supports these versions, so we can skip those as well. --------- Co-authored-by: Stanislav (Stas) Katkov <[email protected]>
cheddar-me · Sep 26, 2024 · fdb4afb · fdb4afb
1 parent 76ee8b0
commit fdb4afb
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 34 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -14,7 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         ruby: ["3.0", "3.1", "3.2", "3.3"]
-        gemfile: [ "rails_6_1", "rails_7_0", "rails_7_2"]
+        gemfile: ["rails_7_0", "rails_7_2"]
         exclude:
           - ruby: "3.0"
             gemfile: "rails_7_2"

diff --git a/.gitignore b/.gitignore
@@ -18,5 +18,5 @@ gemfiles/*.lock
 Gemfile.lock
 .ruby-version
 pkg
-
+.vscode/
 
diff --git a/Appraisals b/Appraisals
@@ -1,7 +1,3 @@
-appraise "rails-6-1" do
-  gem "rails", "~> 6.1.0"
-end
-
 appraise "rails-7-0" do
   gem "rails", "~> 7.0.0"
 end

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 
 This format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+- Remove official support for Rails 6 versions. It still works, but we don't test against it anymore.
+
 ## 0.19.0
 ### Added
 - Add support for rails 7.2, but leave out rails 7.1 support. This is because ActionView has a breaking bug in 7.1 that renders the template back as a string

diff --git a/README.md b/README.md
@@ -1,11 +1,14 @@
 # Pbbuilder
 PBBuilder generates [Protobuf](https://developers.google.com/protocol-buffers) Messages with a simple DSL similar to the [JBuilder](https://rubygems.org/gems/jbuilder) gem.
 
+## Requirements
+This gem only supports Rails 7.0 and Rails 7.2, **7.1 is not supported**.
 
-At least Rails 6.1 is required and rails 7.1 is currently not supported.
 There currently is a regression in ActionView (the part of Rails which renders) that forces rendered objects into strings, but for Pbbuilder we need the raw objects.
 This is only present in Rails 7.1, and a fix is released in Rails 7.2. https://github.com/rails/rails/pull/51023
 
+It might work on rails v6 (it worked previously), but we don't guarantee that and don't test against these versions anymore.
+
 ## Compatibility with jBuilder
 We don't aim to have 100% compitability and coverage with jbuilder gem, but we closely follow jbuilder's API design to maintain familiarity.
 

diff --git a/gemfiles/rails_6.gemfile b/gemfiles/rails_6.gemfile
diff --git a/gemfiles/rails_6_1.gemfile b/gemfiles/rails_6_1.gemfile
diff --git a/gemfiles/rails_7.gemfile b/gemfiles/rails_7.gemfile