Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle recursive protobuf messages #48

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

skatkov
Copy link
Contributor

@skatkov skatkov commented Nov 1, 2023

In previous implementation, CollectionRenderer cannot handle recursive protobuf messages, but this fix resolves it.

@skatkov skatkov changed the title handle descending protobuf messages handle recursive protobuf messages Nov 1, 2023
Copy link

@jujustayfly jujustayfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skatkov skatkov force-pushed the fix-recurring-message-rendering branch from dcdaaad to 456c283 Compare November 2, 2023 10:32
@skatkov skatkov merged commit 347b949 into main Nov 2, 2023
8 checks passed
@skatkov skatkov deleted the fix-recurring-message-rendering branch November 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants