Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fragment caching, partial as first argument #52

Merged
merged 4 commits into from
Nov 17, 2023
Merged

fragment caching, partial as first argument #52

merged 4 commits into from
Nov 17, 2023

Conversation

skatkov
Copy link
Contributor

@skatkov skatkov commented Nov 6, 2023 •
edited
Loading

Adds ability to provide partial as first argument.

pb.friends "racers/racer", as: :racer, collection: @racers

Also in detail explains how fragment caching works now and tests that verify that it stays working.

@skatkov skatkov requested a review from a team November 6, 2023 10:45
svanhesteren
svanhesteren reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@svanhesteren svanhesteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good I think, but when facing the www I think we can do a bit better in the use of english in the comments. This will look a bit more professional. Hope you agree with me. 🙂

lib/pbbuilder/template.rb Outdated Show resolved Hide resolved
lib/pbbuilder/template.rb Outdated Show resolved Hide resolved
lib/pbbuilder/template.rb Outdated Show resolved Hide resolved
lib/pbbuilder/template.rb Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/test_helper.rb Outdated Show resolved Hide resolved
@skatkov
Copy link
Contributor Author

skatkov commented Nov 6, 2023

@svanhesteren thanks for a review! Adjusted PR according to your feedback

@skatkov skatkov merged commit ec2607d into main Nov 17, 2023
8 checks passed
@skatkov skatkov deleted the frag-cache branch November 17, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanhesteren svanhesteren svanhesteren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skatkov @svanhesteren