Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude incompatible Rails versions #54

Closed
wants to merge 2 commits into from
Closed

Exclude incompatible Rails versions #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee223a9
Exclude incompatible Rails versions
skatkov Feb 14, 2024
65e3034
test against rails main again
skatkov Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
ruby: ["3.0", "3.1", "3.2", "3.3"]

gemfile: [ "rails_6_1", "rails_7_0"]
gemfile: [ "rails_6_1", "rails_7_0", "rails_head"]
experimental: [false]

#include:
Expand Down
9 changes: 7 additions & 2 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ appraise "rails-7-0" do
gem "rails", "~> 7.0.0"
end

appraise "rails-7-1" do
gem "rails", "~> 7.1.0"
# Currently there are no Rails 7.1 releases that are compatible with pbbuilder, but 7.1.4 should include a fix that will make it compatible again.
#appraise "rails-7-1" do
# gem "rails", "~> 7.1.0"
#end

appraise "rails-head" do
gem "rails", github: "rails/rails", branch: "main"
end
10 changes: 0 additions & 10 deletions gemfiles/rails_7_1.gemfile
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions gemfiles/rails_head.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ source "https://rubygems.org"

gem "rake"
gem "appraisal"
gem "ruby-lsp"
gem "rails", github: "rails/rails", branch: "main"

gemspec path: "../"
7 changes: 5 additions & 2 deletions pbbuilder.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files`.split("\n")
spec.test_files = `git ls-files -- test/*`.split("\n")

spec.add_dependency "google-protobuf"
spec.add_dependency "activesupport"
spec.add_runtime_dependency "google-protobuf"
# Rails has shipped an incompatible change in ActiveView, that was reverted in later versions.
# @see https://github.com/rails/rails/pull/51023
excluded_versions = ["7.1.0", "7.1.1", "7.1.2", "7.1.3"].map { |v| "!= #{v}" }
spec.add_runtime_dependency "activesupport", *excluded_versions
spec.add_development_dependency 'm'
spec.add_development_dependency "pry"
end
Loading