Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images (May 2021) #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karmix
Copy link

@karmix karmix commented Oct 4, 2021

Move main.sh to chef_server_setup.sh in packer-chef-highperf-centos-ami repo to resolve circular dependency, and also remove before.sh, which was already moved to https://github.com/chef-customers/packer-chef-highperf-centos-ami/blob/c2f04061c70f1f1534226561d33d4abcfdb2689d/scripts/install_admin_tools.sh .

@irvingpop
Copy link

🤔 wouldn't this change break this line in the image creation scripts?

https://github.com/chef-customers/packer-chef-highperf-centos-ami/blob/c2f04061c70f1f1534226561d33d4abcfdb2689d/scripts/marketplace_dl.sh#L19-L20

or do you have another PR to that repo to import it?

@karmix
Copy link
Author

karmix commented Oct 5, 2021

Correct, there is another PR, chef-customers/packer-chef-highperf-centos-ami#6 , which needs to be discussed and merged before this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants