Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm/fix vagrant undefined hasmap except #4912

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

rickmarry
Copy link
Contributor

@rickmarry rickmarry commented Apr 5, 2021

🔩 Description: What code changed, and why?

This change fixes the issue the "undefined hashmap method except with Vagrant 2.2.7" issue, which was keeping our ./ec2/Vagrantfile from working properly to provision an ec2 instance.

This change simply applies the workaround initially documented here: mitchellh/vagrant-aws#566 (comment)

⛓️ Related Resources

👍 Definition of Done

The Hasmap method except issue listed about should no longer prevent us from provisioning an ec2 insance using vagrant up

👟 How to Build and Test the Change

Following the directions in ./ec2/README.md, we should once again be able to provision and use an ec2 instance

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 5, 2021

Deploy preview for chef-automate processing.

Building with commit affb609

https://app.netlify.com/sites/chef-automate/deploys/606d09971bef9a00074cc5c5

@rickmarry rickmarry requested a review from kalroy April 5, 2021 19:08
@kalroy kalroy force-pushed the rm/fix-vagrant-undefined-hasmap-except branch from abec9be to affb609 Compare April 7, 2021 01:23
@rickmarry rickmarry merged commit 578d518 into master Apr 8, 2021
@rickmarry rickmarry deleted the rm/fix-vagrant-undefined-hasmap-except branch April 8, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants