Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhel: Check for networking-scripts before removal #1532

Merged
merged 1 commit into from
Nov 12, 2023
Merged

rhel: Check for networking-scripts before removal #1532

merged 1 commit into from
Nov 12, 2023

Conversation

Rendanic
Copy link
Contributor

@Rendanic Rendanic commented Oct 7, 2023

Bugfix for packer build on centos-stream-9.

Description

The cleanup for centos-stream-9 fails during execution.

This is caused due to missing files in /etc/sysconfig/network-scripts/ifcfg-*.

Simple to reproduce:
packer build -only=virtualbox-iso.vm -var-file=./os_pkrvars/centos/centos-stream-9-x86_64.pkrvars.hcl packer_templates

==> virtualbox-iso.vm: + for ndev in /etc/sysconfig/network-scripts/ifcfg-*
==> virtualbox-iso.vm: ++ basename '/etc/sysconfig/network-scripts/ifcfg-*'
==> virtualbox-iso.vm: + '[' 'ifcfg-*' '!=' ifcfg-lo ']'
==> virtualbox-iso.vm: + sed -i '/^HWADDR/d' '/etc/sysconfig/network-scripts/ifcfg-*'
==> virtualbox-iso.vm: sed: can't read /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
==> virtualbox-iso.vm: Provisioning step had errors: Running the cleanup provisioner, if present...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Rendanic Rendanic marked this pull request as ready for review October 7, 2023 21:03
@Rendanic Rendanic requested review from Stromweld and a team as code owners October 7, 2023 21:03
Stromweld
Stromweld approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stromweld Stromweld merged commit d54f811 into chef:main Nov 12, 2023
79 of 211 checks passed
@Rendanic Rendanic deleted the prcentos branch November 13, 2023 04:47
hunleyd added a commit to hunleyd/bento that referenced this pull request Nov 23, 2023
@hunleyd
Merge branch 'main' of github.com:chef/bento
4756689 
* 'main' of github.com:chef/bento:
  feat: remove fedora 37 and add fedora 39 (chef#1535)
  rhel: Check for networking-scripts before removal (chef#1532)
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
@Rendanic @raykrist
rhel: Check for networking-scripts before removal (chef#1532)
40a6e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Stromweld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rendanic @Stromweld