Adds possibility to configure failure flag #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be willing to add tests, but the CI seems not to be operational (related #81). |
swistak35
force-pushed
the
rl-add-possibility-to-set-failure-flag
branch
2 times, most recently
from
e1820c7
to
1810eca
Compare
swistak35
force-pushed
the
rl-add-possibility-to-set-failure-flag
branch
from
1810eca
to
bd77570
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Any chance to merge this? I believe it's very not controversial change :) |
So this has been rebased to be separate from #83 ? Need a DCO and I need to double-check what's up with the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds possibility to set failureflag option.
Failure flag is the checkbox "Enable actions for stops with errors" in "Recovery" tab of a service.
Issues Resolved
Related discussion: #36 (comment)
Without this checkbox enabled, Windows won't even look into win32 exit code to check whether process has failed or not.
Check List