Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-science confirmation dialog #2618

Closed
wants to merge 9 commits into from

Conversation

wadjih-bencheikh18
Copy link
Member

@wadjih-bencheikh18 wadjih-bencheikh18 commented Aug 15, 2023

I couldn't migrate modals in KeysListenerTracker and FilterTable because the modal have 3 options, so we will able to use react-science after improving ConfirmModal

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Aug 15, 2023 that may be closed by this pull request
9 tasks
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f276fa) 52.95% compared to head (996d638) 52.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2618   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files          50       50           
  Lines        2487     2487           
  Branches       88       88           
=======================================
  Hits         1317     1317           
  Misses       1169     1169           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 996d638
Status: ✅  Deploy successful!
Preview URL: https://eb29380d.nmrium.pages.dev
Branch Preview URL: https://2609-confirmation-dialog.nmrium.pages.dev

View logs

@lpatiny
Copy link
Member

lpatiny commented Sep 14, 2023

If we press Enter when the dialog is there we get a focus around the dialog and this should not be the case.

image

@targos
Copy link
Member

targos commented Oct 19, 2023

This PR will need to be updated now that the styling issues are fixed in react-science.

@wadjih-bencheikh18
Copy link
Member Author

This PR will need to be updated now that the styling issues are fixed in react-science.

The outline problem is solved but there is an issue in the new release
zakodium-oss/react-science#575

@targos
Copy link
Member

targos commented Oct 23, 2023

There's a problem (overflow) with the vertical toolbar:
CleanShot 2023-10-23 at 10 23 56

@wadjih-bencheikh18
Copy link
Member Author

This PR need to be closed

@targos targos closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants