feat: also emit change events when in readonly mode #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be more straight-forward to use a JStructureView-js component for that? |
|
OCL-JS does not implement all OCL UI components one to one. There exists a "legacy" (non generic) variant of it (StructureView). Short answer, such a component does currently not exist (same as JEditableStructureView, JChemistryView, JEditableChemistryView). This can maybe be addressed in the future. Currently I'm focusing on getting a first production version ready openchemlib-vaadin. |
|
@targos Would you mind merging this pull request and creating a new OCL-JS release so I can finally release my first version of openchemlib-vaadin? Thanks a lot for your support. |
targos
changed the title
|
@targos thanks a lot, it's a pleasure working so efficiently with you guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to use the the editor component with disabled editor functionality (readonly=true), while still having the possibility to support dnd and paste operations. Therefore it it is crucial to get those events also in readonly mode.