-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water bridge 2nd Order implementation #230
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## water_bridge #230 +/- ##
================================================
+ Coverage 94.50% 94.72% +0.21%
================================================
Files 21 22 +1
Lines 1548 1650 +102
================================================
+ Hits 1463 1563 +100
- Misses 85 87 +2 ☔ View full report in Codecov by Sentry. |
added code for 2nd order water bridges
4528599
to
4e34243
Compare
I moved the code to a new module to make things clearer, it was getting quite daunting in the I also simplified the code a bit since there was a bit too much repetition in the metadata part to my liking. Next is getting in a less "for-loop" approach to implementing each higher order and finding something more generalisable. Most likely using |
Ah nice, true it gets a little bit overwhelming with the Ah, somehow I didn't think about the |
8036a40
to
b7a536e
Compare
Changes made:
we would need to see if we make the order input then in the Fingerprint class and have a default, currently being 1
that the user can then input in the Fingerprint class.
As for the higher water bridge orders we would need to see how we do the recognition of interactions within the
water-water analysis multiple times. Maybe through some looping like some step wise matching