Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water bridge 2nd Order implementation #230

Merged
merged 9 commits into from
Dec 29, 2024
Merged

Conversation

talagayev
Copy link
Collaborator

Changes made:

  • Addition of code for 2nd Order water bridges
  • Implementation of input variable order

we would need to see if we make the order input then in the Fingerprint class and have a default, currently being 1
that the user can then input in the Fingerprint class.

As for the higher water bridge orders we would need to see how we do the recognition of interactions within the
water-water analysis multiple times. Maybe through some looping like some step wise matching

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.72%. Comparing base (72e4854) to head (2066772).
Report is 1 commits behind head on water_bridge.

Files with missing lines Patch % Lines
prolif/fingerprint.py 93.33% 2 Missing ⚠️
prolif/interactions/base.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           water_bridge     #230      +/-   ##
================================================
+ Coverage         94.50%   94.72%   +0.21%     
================================================
  Files                21       22       +1     
  Lines              1548     1650     +102     
================================================
+ Hits               1463     1563     +100     
- Misses               85       87       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

talagayev and others added 2 commits December 27, 2024 00:54
@cbouy cbouy force-pushed the water_bridge_2nd_order branch from 4528599 to 4e34243 Compare December 26, 2024 23:54
@cbouy
Copy link
Member

cbouy commented Dec 27, 2024

I moved the code to a new module to make things clearer, it was getting quite daunting in the fingerprint.py file.

I also simplified the code a bit since there was a bit too much repetition in the metadata part to my liking.

Next is getting in a less "for-loop" approach to implementing each higher order and finding something more generalisable. Most likely using networkx to build the actual water network and then finding all shortest paths of length <order> in the graph that go from <ligand residue> to <protein residue>. Let's see if I have time to do that before the new year

@talagayev
Copy link
Collaborator Author

I moved the code to a new module to make things clearer, it was getting quite daunting in the fingerprint.py file.

I also simplified the code a bit since there was a bit too much repetition in the metadata part to my liking.

Next is getting in a less "for-loop" approach to implementing each higher order and finding something more generalisable. Most likely using networkx to build the actual water network and then finding all shortest paths of length in the graph that go from to . Let's see if I have time to do that before the new year

Ah nice, true it gets a little bit overwhelming with the metadata.

Ah, somehow I didn't think about the networkx option. I would probably be on holidays till the new year, but would be
able to take a look from January 2nd to assist :)

@cbouy cbouy force-pushed the water_bridge_2nd_order branch from 8036a40 to b7a536e Compare December 28, 2024 15:56
@cbouy cbouy merged commit 9cb60d2 into water_bridge Dec 29, 2024
8 checks passed
@cbouy cbouy deleted the water_bridge_2nd_order branch December 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants