-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage improvement. #462
base: master
Are you sure you want to change the base?
Conversation
By analyzing the blame information on this pull request, we identified @RoyMontoya, @whoshuu and @jivimberg to be potential reviewers |
One thing that should be really tested is the creation and migration of the database |
Ok I will test them too then :) |
@sibeliusseraphini On last commit I renamed |
@nurolopher the only problem of changing a public API name is that you could introduce a breaking change to another person codes. However, in this case, I think this method is used almost exclusively by Sugar implementation, so no problem. Thanks, I will merge it this week |
👍 |
@nurolopher could you check the conflicts? |
Code coverage has been improved by 4% overall.